diff options
| author | Arthur Hanson Rasmusson <arthur@vgpu.io> | 2026-11-16 18:46:47 -0500 |
|---|---|---|
| committer | Arthur Hanson Rasmusson <arthur@vgpu.io> | 2026-11-16 18:46:47 -0500 |
| commit | f0e34c4fb345f907727fdd3aa401465c377ae81d (patch) | |
| tree | 67293d1e8d2f7b47183cdd41d3746ad9cfc5a42a /kernel/gsp_phys_booter.c | |
| parent | a644d2540d3a25c8ed6959548c6107f76e72ad89 (diff) | |
| download | open-iov-f0e34c4fb345f907727fdd3aa401465c377ae81d.tar.gz open-iov-f0e34c4fb345f907727fdd3aa401465c377ae81d.zip | |
vgsp: eng89p - match the CALL header, not interior methods, for DRAW_IAB
The c996-c1001 DRAW-SCAN false-positive: a 4353-word op=1 state run whose
m0=0x804 has 0x3910 at interior offset 0xC43, so the scan claimed the draw
was present, forced a 4353-word 'draw slice', and the real CALL header
(op=5 cnt=10 m0=0x3910) never reached the held-call path. A CALL can only
be a run header, so match m0 only (booter window scan and the service
walker/chunk scan).
Diffstat (limited to 'kernel/gsp_phys_booter.c')
| -rw-r--r-- | kernel/gsp_phys_booter.c | 20 |
1 files changed, 12 insertions, 8 deletions
diff --git a/kernel/gsp_phys_booter.c b/kernel/gsp_phys_booter.c index 0e319c1..4918731 100644 --- a/kernel/gsp_phys_booter.c +++ b/kernel/gsp_phys_booter.c @@ -19164,14 +19164,18 @@ static bool gsp_phys_gr_mme_window_has_draw_ia(const u32 *win, u32 n) if ((op == 1u || op == 3u || op == 5u) && cnt && r + 1u + cnt <= n) span = 1u + cnt; - for (k = 0; k < span; k++) { - u32 m = ((h & 0xfffu) << 2) + 4u * k; - - if (k && op != 1u && op != 3u) - break; - if (m == 0x3800u + 34u * 8u) - return true; - } + /* + * eng89p: only the RUN HEADER's own method selects a CALL. + * The client's DRAW_IAB call is a distinct header + * (0xa00a0e44: op=5 ONE_INCR, cnt=10, m0=0x3910). Matching + * interior words of a wide op=1/3 run produced the c997-c1001 + * false positive (a 4353-word state run with m0=0x804 whose + * interior offset happens to be 0x3910), so a real CALL never + * reached the held-call path. + */ + if (((h & 0xfffu) << 2) == 0x3800u + 34u * 8u) + return true; + (void)k; r += span; } return false; |
