From 9c09d3bf22a469b1d5a6d73bc65baf87d2770f21 Mon Sep 17 00:00:00 2001 From: Arthur Hanson Rasmusson Date: Mon, 16 Nov 2026 13:12:37 -0500 Subject: vgsp: eng89g - admit the real draw markers (op=4 BEGIN, op=5 CALL) RT-ADMIT-BLOCK on c934-c938 showed the persisted bind (mask=1, pchan=0x1000013, B=0x20400000 W=0x780 H=0x438) was always refused by the draw-marker guard: the client encodes BEGIN 0x1618 as an immd13 (op 4) and CALL_MME_MACRO(34) 0x3910 as ONE_INCR (op 5, 0xa00a0e44), while the guard only accepted the op=1 INC form. Accept ops 1/3/4/5 and match the method, which flips has_draw to 1 and lets the persisted admission reach the replay lane. --- kernel/gsp_sema_service.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) (limited to 'kernel') diff --git a/kernel/gsp_sema_service.c b/kernel/gsp_sema_service.c index 1487f86..140e8e7 100644 --- a/kernel/gsp_sema_service.c +++ b/kernel/gsp_sema_service.c @@ -12231,10 +12231,19 @@ static bool svc_gl_win_has_draw(const u8 *buf, u32 len) if (!buf) return false; for (i = 0; i + 4u <= len; i += 4u) { - u32 w, m; + u32 w, op, m; memcpy(&w, buf + i, 4); - if ((w & 0xe0001fffu) != 0x20000000u) + op = (w >> 29) & 7u; + /* + * The client encodes these real draw markers as different + * run forms: CALL_MME_MACRO(34) 0x3910 arrives as ONE_INCR + * (op 5, header 0xa00a0e44) and BEGIN 0x1618 as an immd13 + * (op 4). Accept the method-stream ops rather than only the + * INC form; data words that alias these methods are rare and + * the per-window bind validity is not required on this path. + */ + if (op != 1u && op != 3u && op != 4u && op != 5u) continue; m = (w & 0x1fffu) << 2; if (m == 0x1618u || m == 0x0d78u || m == 0x3910u) -- cgit v1.2.3