From 42a9a97be43574e7449f90300fea28a54ffb4e66 Mon Sep 17 00:00:00 2001 From: Arthur Hanson Rasmusson Date: Mon, 16 Nov 2026 11:50:47 -0500 Subject: vgsp: eng89d - admit the draw on a bind from another channel c910 proved the persisted bind arrives on the X/2D channel (RT-PERSIST h=0x1000013 B=0x20400000 W=0x780 H=0x438) while the beef draw window is on 0xbeef0100, so the eng89c channel equality refused the exact window it was meant to admit. The stored channel is now diagnostic only; the draw-marker guard, the surface-class validity and the per-session clear remain. --- kernel/gsp_sema_service.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'kernel/gsp_sema_service.c') diff --git a/kernel/gsp_sema_service.c b/kernel/gsp_sema_service.c index 9a6fde9..66ab29b 100644 --- a/kernel/gsp_sema_service.c +++ b/kernel/gsp_sema_service.c @@ -12344,8 +12344,17 @@ static bool svc_gl_window_drawwin_ok(const u8 *buf, u32 len, u32 start_off, * persisted bind when one is known; the replay context's RT state * comes from the channel shadow, not from this window. */ + /* + * The bind may legitimately come from the X/2D channel that owns the + * scanout surface (c910: RT-PERSIST h=0x1000013 B=0x20400000 + * W=0x780 H=0x438) while the draw arrives on the GL/beef channel + * (0xbeef0100) that renders into it, so the stored channel is a + * diagnostic only. A real draw marker is required so a data blob + * cannot ride the persisted bind into the replay lane; the state is + * cleared per session (svc_session_flush). + */ if (READ_ONCE(svc_gl_rtp) && svc_gl_rtp_valid() && - READ_ONCE(svc_gl_rtp_chan) == h && svc_gl_win_has_draw(buf, len)) { + svc_gl_win_has_draw(buf, len)) { static u32 rtp_adm_log; if (rtp_adm_log < 16u) { -- cgit v1.2.3