diff options
| author | Arthur Hanson Rasmusson <arthur@vgpu.io> | 2026-09-21 13:06:51 -0400 |
|---|---|---|
| committer | Arthur Hanson Rasmusson <arthur@vgpu.io> | 2026-09-21 13:06:51 -0400 |
| commit | c3a295efd1b1132bbaa5d422cd05b3fa8e89a8bf (patch) | |
| tree | f74bd7724153cd9d870688df3ff75274cd5000da /driver/bar | |
| parent | 5d4d26f8e773f2871c1b5c9266b82495d390970e (diff) | |
| download | open-iov-c3a295efd1b1132bbaa5d422cd05b3fa8e89a8bf.tar.gz open-iov-c3a295efd1b1132bbaa5d422cd05b3fa8e89a8bf.zip | |
kernel: Fix GSP emulation shadow binding, eventfd wiring, RPC livelocks + docs suite + repo reorg
CRITICAL FIXES (guest driver bring-up):
- gsp_emulation.c: emulation engine bound to the WRONG BAR0 - it polled the
host physical BAR0 (bars[0].vaddr ioremap) for the doorbell and read RPCs
from a local dma_alloc_wc buffer, while the guest writes land in the
vzalloc'd bar0_shadow. The RPC path could never work; PBA writes even
corrupted the host GPU's physical BAR0+0x3000. gsp_emu_init now binds
exclusively to bar0_shadow (doorbell/mailbox/PBA aliases;
shared_mem_dma==0 marks the alias so cleanup never dma_free's it).
- main.c SET_IRQS: DATA_EVENTFD eventfds were DISCARDED ('TODO' + kfree) -
the guest never received MSI-X completions. Full wiring now:
eventfd_ctx_fdget per vector, fd -1 clears, dev_close releases refs.
gsp_emu_inject_completion_interrupt looks up vgpu->irqs[0].trigger LIVE
(init-time copy was permanently NULL since QEMU wires after gsp_emu_init).
- gsp_rpc_client.c: BAR_TRAP/MIGRATE in emulation mode called
gsp_rpc_submit_raw which rings the SAME doorbell the thread polls -
self-triggered RPC livelock + multi-second stalls. Now fail fast with
-ENOTSUPP + pr_warn_ratelimited (guest BAR access is direct MMIO).
MORE FIXES:
- main.c: nv_vgpu_config_write returned SIZE_MAX (while(count--) wrap) and
was dead code while the VFIO write handler did unfiltered byte copies
(guest could rewrite vendor ID/BARs). Return fixed; VFIO write handler
now routes through the per-register filter.
- kernel/Makefile: M=$(PWD) used the env var which is stale when invoked
via the top-level make (pointed at repo root -> kbuild silently built
NOTHING; explains every 'stale .ko' incident). Now M=$(CURDIR).
- Warnings sweep: header prototypes for mdev/type functions, format casts
in gsp_comm.c DRY-RUN logs, unused variable.
ROBUSTNESS (harness/tooling):
- vgpu_vm.py: run had no timeout (start could block forever);
guest_shell recv could block forever on a wedged guest. Both now bounded;
guest_shell pre-flights guest-ping and reports wedge diagnostics.
- stack_manager.sh: qemu/qemu-debug now launch via the vgpu_vm.py harness
(workflow rule: never raw QEMU).
REPO REORGANIZATION:
- driver/ (legacy guest-side gsp-vgpu.ko) moved to legacy-driver-guest/
(reference only, not built; README explains). 3 legacy un-buildable test
files moved to legacy-driver-guest/kernel-tests/. Top-level Makefile
cleaned of the dead DRIVER_DIR reference.
DOCUMENTATION SUITE (new):
- docs/GSP_EMULATION_ARCHITECTURE.md - emulator deep-dive: shadow BAR0
model, doorbell protocol, dispatch table, MSI-X path, lifecycle, memory-
model caveats
- docs/DEBUGGING.md - QEMU GDB stub workflow, serial console, QMP NMI,
failure taxonomy, full bring-up validation checklist, EPT-livelock case
study, version-matrix discipline
- docs/ONBOARDING.md - repo tour, coding standards (incl. virt_to_phys /
dma_addr_t / get-put rules), first build & test
- docs/VERSION_UPGRADE.md - end-to-end new-driver-version procedure
(firmware fetch, Ghidra analysis, configs, signatures, validation)
- docs/PERFORMANCE.md - bare-metal A/B methodology + targets
- README.md doc index; STATE.md refreshed; DEVELOPMENT_WORKFLOW.md corrected
(load order: open-iov-vfio BEFORE nvidia; stock-driver blacklist note)
Diffstat (limited to 'driver/bar')
| -rw-r--r-- | driver/bar/gsp_bar.c | 242 |
1 files changed, 0 insertions, 242 deletions
diff --git a/driver/bar/gsp_bar.c b/driver/bar/gsp_bar.c deleted file mode 100644 index aa3ed62..0000000 --- a/driver/bar/gsp_bar.c +++ /dev/null @@ -1,242 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* - * GSP vGPU-IO Driver - BAR Emulation - */ - -#include "gsp_core.h" -#include <linux/slab.h> -#include <linux/vmalloc.h> - -/* BAR Emulation Ops */ -static int gsp_bar_trap_handler(struct gsp_vf *vf, struct gsp_bar_trap_payload *trap) -{ - struct gsp_bar_state *bar = &vf->bar_state; - struct gsp_bar_trap_response resp = {0}; - size_t resp_size = sizeof(resp); - int ret; - - /* Validate BAR index (we only support BAR1) */ - if (trap->bar_index != 1) - return -EINVAL; - - /* Validate offset */ - if (trap->offset >= bar->aperture_size) - return -ERANGE; - - /* Check ForceBarAccess */ - if (bar->force_access && vf->id != bar->force_vf) - return -EPERM; - - /* In emulation mode, handle locally */ - if (emulation_mode) { - /* Simulate BAR trap handling */ - if (trap->trap_type == GSP_BAR_WRITE) { - /* Config write - update aperture */ - bar->aperture_offset = trap->offset; - bar->aperture_size = trap->value; - } else if (trap->trap_type == GSP_BAR_ATOMIC) { - /* Force access control */ - bar->force_access = trap->offset ? true : false; - bar->force_vf = trap->offset ? vf->id : 0; - } - resp.value = 0; - return 0; - } - - /* Forward to GSP BAR trap handler (0x04CB8188) */ - ret = gsp_rpc_send_sync(vf->gsp->rpc, GSP_RPC_BAR_TRAP, - trap, sizeof(*trap), &resp, &resp_size); - - return ret; -} - -/* Aperture Configuration */ -static int gsp_bar_config_aperture(struct gsp_vf *vf, uint64_t offset, uint64_t size) -{ - struct gsp_bar_state *bar = &vf->bar_state; - struct gsp_bar_trap_payload payload = {0}; - struct gsp_bar_trap_response resp = {0}; - size_t resp_size = sizeof(resp); - int ret; - - /* Validate alignment (4KB) */ - if (offset & 0xFFF || size & 0xFFF) - return -EINVAL; - - /* Validate max size (256KB per firmware) */ - if (size > 0x40000) - return -EINVAL; - - /* In emulation mode, handle locally */ - if (emulation_mode) { - bar->aperture_offset = offset; - bar->aperture_size = size; - return 0; - } - - payload.bar_index = 1; - payload.trap_type = GSP_BAR_WRITE; /* Config write */ - payload.offset = offset; - payload.value = size; - payload.size = 8; - payload.vf_id = vf->id; - - ret = gsp_rpc_send_sync(vf->gsp->rpc, GSP_RPC_BAR_TRAP, - &payload, sizeof(payload), &resp, &resp_size); - if (!ret) { - bar->aperture_offset = offset; - bar->aperture_size = size; - } - - return ret; -} - -/* ForceBarAccess Control */ -int gsp_bar_force_access(struct gsp_vf *vf, bool enable) -{ - struct gsp_bar_state *bar = &vf->bar_state; - struct gsp_bar_trap_payload payload = {0}; - struct gsp_bar_trap_response resp = {0}; - size_t resp_size = sizeof(resp); - int ret; - - /* In emulation mode, handle locally */ - if (emulation_mode) { - bar->force_access = enable; - bar->force_vf = enable ? vf->id : 0; - return 0; - } - - payload.bar_index = 1; - payload.trap_type = GSP_BAR_ATOMIC; /* Force access control */ - payload.offset = enable ? 1 : 0; - payload.value = enable ? vf->id : 0; - payload.size = 8; - payload.vf_id = vf->id; - - ret = gsp_rpc_send_sync(vf->gsp->rpc, GSP_RPC_BAR_TRAP, - &payload, sizeof(payload), &resp, &resp_size); - if (!ret) { - bar->force_access = enable; - bar->force_vf = enable ? vf->id : 0; - } - - return ret; -} - -/* State Save for Migration */ -static int gsp_bar_save_state(struct gsp_vf *vf, void *buf, size_t *size) -{ - struct gsp_bar_state *bar = &vf->bar_state; - size_t needed = sizeof(*bar) + bar->backing_size; - - if (!buf || *size < needed) - return -ENOSPC; - - memcpy(buf, bar, sizeof(*bar)); - if (bar->backing_store && bar->backing_size > 0) - memcpy(buf + sizeof(*bar), bar->backing_store, bar->backing_size); - - *size = needed; - return 0; -} - -/* State Restore for Migration */ -static int gsp_bar_restore_state(struct gsp_vf *vf, void *buf, size_t size) -{ - struct gsp_bar_state *bar = &vf->bar_state; - size_t min_size = sizeof(*bar); - - if (!buf || size < min_size) - return -EINVAL; - - memcpy(bar, buf, sizeof(*bar)); - - if (size > min_size && bar->backing_size > 0) { - if (!bar->backing_store) { - bar->backing_store = vzalloc(bar->backing_size); - if (!bar->backing_store) - return -ENOMEM; - } - memcpy(bar->backing_store, buf + min_size, - min(size - min_size, bar->backing_size)); - } - - /* Reconfigure BAR in GSP */ - return gsp_bar_config_aperture(vf, bar->aperture_offset, bar->aperture_size); -} - -/* VF BAR Initialization */ -int gsp_vf_bar_init(struct gsp_vf *vf) -{ - struct gsp_bar_state *bar = &vf->bar_state; - int ret; - - /* Initialize with config values */ - bar->aperture_offset = vf->bar1_offset; - bar->aperture_size = vf->bar1_size; - bar->force_access = false; - bar->force_vf = 0; - bar->backing_store = NULL; - bar->backing_size = 0; - - /* Allocate backing store (max 256KB) */ - if (bar->aperture_size > 0) { - bar->backing_size = min(bar->aperture_size, (uint64_t)0x40000); - bar->backing_store = vzalloc(bar->backing_size); - if (!bar->backing_store) - return -ENOMEM; - } - - /* Configure aperture in GSP (skip in emulation mode) */ - if (!emulation_mode) { - ret = gsp_bar_config_aperture(vf, bar->aperture_offset, bar->aperture_size); - if (ret) { - dev_err(vf->gsp->dev, "VF %u: BAR aperture config failed: %d\n", vf->id, ret); - goto err_backing; - } - } else { - dev_info(vf->gsp->dev, "VF %u: BAR1 initialized in emulation mode [0x%llx, 0x%llx)\n", - vf->id, bar->aperture_offset, bar->aperture_offset + bar->aperture_size); - } - - dev_info(vf->gsp->dev, "VF %u: BAR1 initialized [0x%llx, 0x%llx)\n", - vf->id, bar->aperture_offset, bar->aperture_offset + bar->aperture_size); - - return 0; - -err_backing: - vfree(bar->backing_store); - bar->backing_store = NULL; - bar->backing_size = 0; - return ret; -} - -/* VF BAR Cleanup */ -void gsp_vf_bar_fini(struct gsp_vf *vf) -{ - struct gsp_bar_state *bar = &vf->bar_state; - - vfree(bar->backing_store); - bar->backing_store = NULL; - bar->backing_size = 0; - - dev_info(vf->gsp->dev, "VF %u: BAR1 cleaned up\n", vf->id); -} - -/* BAR Trap Entry Point (called from ISR/notification) */ -int gsp_vf_bar_trap(struct gsp_vf *vf, struct gsp_bar_trap_payload *trap) -{ - return gsp_bar_trap_handler(vf, trap); -} - -/* Migration Interface */ -int gsp_migration_bar_save(struct gsp_vf *vf, void *buf, size_t *size) -{ - return gsp_bar_save_state(vf, buf, size); -} - -int gsp_migration_bar_restore(struct gsp_vf *vf, void *buf, size_t size) -{ - return gsp_bar_restore_state(vf, buf, size); -}
\ No newline at end of file |
